[vlc-devel] Re: vlc: svn commit r20440 (courmisch)

[Laurent Aimar]

On Thu, Jun 07, 2007, Rémi Denis-Courmont wrote:
> Le jeudi 7 juin 2007, Laurent Aimar a écrit :
> > On Thu, Jun 07, 2007, Subversion daemon wrote:
> > > r20440 | courmisch | 2007-06-07 18:43:10 +0200 (Thu, 07 Jun 2007) |
> > > 2 lines Changed paths:
> > >    M /trunk/include/vlc_es.h
> > >
> > > Store channels counter to a single byte. We can only handle 32 of
> > > them anyway
> >
> >  Why using uint8_t instead of a perfectly fine int/uint ? (as anyway
> > that does not limit it to 32...)
> 
> Because it limits the margin for nasty integer overflow in 
> multiplications.
 Unless the field was not initialized or was greater then 32 by error (and
in this case the bug should be fixed and not workarounded), it won't
change anything.

-- 
fenrir

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html