[vlc-devel] Re: [PATCH] Allow subpicture regions to all have different alignments

[Bernie Purcell]

On Mon, 2007-06-04 at 23:56 +0200, Jean-Baptiste Kempf wrote:
> On Thu, May 31, 2007, Bernie Purcell wrote :
> > This is part of a former submission stripped out for easier
> > assimilation. It modifies vout_subpictures to use the existing alignment
> > field on each region, rather than the alignment on the subpicture plane
> > itself. Modifications are made to everywhere that depended on the former
> > behaviour, to make it use the new alignment location instead.
> 
> Comments on this patch ?
> 
> 
> -- 
> Jean-Baptiste Kempf
> http://www.jbkempf.com/
> 

Can somebody please look at this patch? Jpsaman requested I break up a
much larger patch, or which this was a part, into smaller ones to make
it easier for people to look at. So far that idea doesn't seem to have
worked. Since all the other patches, and some additional work done since
then all depend on this patch I'm not even in a position of being able
to post them to the list until this one gets accepted.
At the moment the i_align field of subpicture_region_t struct is
completely useless - at only 2 places in the entire source is its' value
read - in freetype.c and quartztext.c to do text alignment; and in the
routine in vout_subpictures.c that calls them the value to this field is
overwritten with the one from the subpicture_t struct immediately before
calling them.
We seem to be using the wrong value - in vout_subpictures.c we are
iterating through a list of subpicture_region_t's and using the
alignment from the parent structure instead of the alignment value for
the region itself - this means that all regions MUST have the same
alignment. If I try to work around this by creating separate
subpicture_t's for each thing I want a different alignment on I run into
VOUT_MAX_SUBPICTURES before I run out of alignments, and there are none
left for anyone else.
Please can someone look at fixing this with the patch I originally
submitted? Even if it creates problems elsewhere it's something that
needs to be done; any problems can always be fixed elsewhere. The
current implementation is limited, and just doesn't appear right, and
this is something we should be doing.
Jpsaman has edited the modules/video_filter/osdmenu.c since I originally
submitted the patch - from what I can see it is just a case of omitting
any changes the patch tries to make to that file from actually being
applied in order for it to work. I don't believe that file requires the
patch any longer.

Thanks

Bernie

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html