[vlc-devel] Re: [PATCH] - fix frees w/out NULLs

[Andrew Stone]

I don't understand how setting a pointer to NULL obfuscates anything. While valgrind may detect these bugs, setting pointers to null will cause the program to crash and make the bug apparent to the user. It will then actually be fixed, rather than causing subtle errors down the road. As it is now, not all errors detected by valgrind are fixed, they just pile up into an unmanageable mess. Just run valgrind on the development code to see an example of this.

-Andrew

----- Original Message ----
From: Laurent Aimar <fenrir at via.ecp.fr>
To: vlc-devel at videolan.org
Sent: Thursday, June 7, 2007 5:32:34 PM
Subject: [vlc-devel] Re: [PATCH] - fix frees w/out NULLs

On Thu, Jun 07, 2007, Pierre d'Herbemont wrote:
>    Seems that you are mixing space/tabs here (more occurence in the rest of
>    the patch though). Spaces should be used.
>    Also, I am not sure we really want to do this. For instance in the above
>    this is absolutely unecessary as we won't reuse the ptr. So I guess your
>    patch add a lot of junk code.
 IMHO it offuscates the code way too much, valgrind will detect those case
perfectly fine anyway...

 Regards,

-- 
fenrir

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html




-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html