[vlc-devel] Extras/contrib libintl.h could still use a patch

[Mark Moriarty]

Lines 91 and 113 generate warnings all the time, due to the test relative to
Apple_CC.

I recommend that lines 91 and 113 of libintl.h, found at
src/gettext/gettext-runtime/intl, be patched so that there's the test for
the existance of __APPLE_CC__ prior to checking the version of it, so that
it will exit cleanly (no more warnings) once it determines that there is no
APPLE_CC.

The patch consists of changing line 91 from:
# if __GNUC__ >= 2 && !(__APPLE_CC__ > 1) && !defined __MINGW32__ &&
!(__GNUC__ == 2 && defined _AIX) && (defined __STDC__ || defined
__cplusplus)

To:
# if __GNUC__ >= 2 && !( (defined __APPLE_CC__ ) && (__APPLE_CC__ > 1) ) &&
!defined __MINGW32__ && !(__GNUC__ == 2 && defined _AIX) && (defined
__STDC__ || defined __cplusplus)

And changing line 113 from:
#if __GNUC__ >= 3 && !(__APPLE_CC__ > 1 && defined __cplusplus)

To:
#if __GNUC__ >= 3 && !(  ((defined __APPLE_CC__ ) && (__APPLE_CC__ > 1))  &&
defined __cplusplus)

(I thought I sent this out as a patch last year, but guess nobody added it.
Not harmful, just an annoyance to see the warnings during the build.)



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070304/6bf02dcb/attachment.html>