[vlc-devel] Re: [PATCH] italic tag support fo MPL2 subtitles

[Roman Bednarek]

On Mon, 5 Mar 2007, Derk-Jan Hartman wrote:

> On 22-feb-2007, at 8:49, Roman Bednarek wrote:
>> On Wed, 21 Feb 2007, Antoine Cellerier wrote:
>> 
>>> I'm not sure if this is relevant to what you're doing (and to the whole
>>> "How do we store inline text styles in VLC" question), but parts of VLC,
>>> like the subsdec.c module already use a text_style_t structure defined
>>> in include/vlc_osd.h. It don't think that it's designed to be inlined
>>> into text but it'd be a good idea IMO to see how you can integrate your
>>> current patch with what's already been done concerning text styles.
>>> AFAIK thedj did most of the work on that part of the text renderer so he
>>> should be able to help.
>>> 
>> 
>>    It is relevant, the goal is to get italic and other tags supported, and 
>> that structure was designed to attach style to text.
>>    I believe the current renderer uses color components in text_style_t 
>> structure. I tried to use it to add italic support, but I had problems with 
>> it, subtitle can be composed of different subregions each with different 
>> text_style, but there is no good way to layout this subregions. Text 
>> renderer adds a border to its subregion (it must do it to correctly paint 
>> background), so adjacent subregions could overlap. It would require a lot 
>> of work and possible redesign to support all tags this way.
>>    On the other hand, mbedding tags into text is simple, easy  and also 
>> good enough for all subtitle styles. So I choosed the simpler approach.
>>    As I said before if it gets accepted I plan add MicroDVD style/color 
>> tags support and later some ssa styles.
>> 
>> Regards
>> Roman Bednarek
>
> Have you been, will you work on this ? Or are you abandoning your efforts ?
> I would love to know.
>
> DJ
>

   As I explained previously my idea was/is to embedd some formatting tags 
into the texts to easily get support for some important tags. The patch 
was not accepted, and it was pointed out, that it is not the best 
solution, and I can olny agree with that, it is not ideal. So adding more 
tags this way does not make sense.
   I did not find any other easy enough (for me anyway :-) ) way of doing 
it yet. I thought about attaching more than one text_style_t structure to 
the subtitle, but I am not sure if it is a good idea, and do not know 
enough about vlc memory management to implement it.

    Regards
    Roman Bednarek

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html