[vlc-devel] Re: [PATCH] wxFileDialog in dialogs.cpp

[Jim Russell]

Hi guys,

heres the diff:  (should i use svn?)

 **@@ -376,8 +376,13 @@
     {
         p_file_generic_dialog->SetMessage( wxU(p_arg->psz_title) );
         p_file_generic_dialog->SetWildcard(
wxU(p_arg->psz_extensions) );+#if wxCHECK_VERSION(2,7,0) // versions
2.7.0 and above+        p_file_generic_dialog->SetWindowStyle(
(p_arg->b_save ? wxSAVE : wxOPEN) |+
      (p_arg->b_multiple ? wxMULTIPLE:0) );+#else // versions below
2.7.0
         p_file_generic_dialog->SetStyle( (p_arg->b_save ? wxSAVE : wxOPEN) |
                                          (p_arg->b_multiple ?
wxMULTIPLE:0) );+#endif
     }

     if( p_file_generic_dialog &&


Hopefully thats close to your coding standards. I checked it against
2.7.0-1as well as
2.6.3 & 2.8.0. Interestingly SetWindowStyle() seemed to work with all 3 wx
versions, but ive done it this way just in case it didnt work with other
previous versions.

If you accept the diff, ill post it to that forum thread as well.

Jim.

On 17/03/07, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>
>
> On Sat, Mar 17, 2007, Rainer Weidenthaler wrote :
> >    But with version 2.8 they changed this to SetWindowStyle. So first
> >    question: are you sure you are compiling vlc with 2.6.3? Probably
> >    providing some more configure options will get the compiler to link
> the
> >    correct version of wxwidgets (use ./configure --help | grep wx )
>
> One another mail about wx...
>
> ok, if you provide a correct patch about that special issue to make
> 0.8.6 compile with wx 2.8.0, I think we can include it.
> But we will not support it, so patch with a good set of #ifdef to get
> wx-2.6.3 and wx-2.8.0 should be accepted, IMHO if YOU provide it.
>
>
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/
>
> --
> This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
> To unsubscribe, please read http://developers.videolan.org/lists.html
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070317/e102ead5/attachment.html>