[vlc-devel] Re: vlc: svn commit r19326 (courmisch)

[Pierre d'Herbemont]

On 15 mars 07, at 18:36, Rémi Denis-Courmont wrote:

> Le mercredi 14 mars 2007 18:10, Subversion daemon a écrit :
>> r19326 | courmisch | 2007-03-14 17:10:14 +0100 (Wed, 14 Mar 2007) | 2
>> lines Changed paths:
>>    M /trunk/src/vlc.c
>>
>> Code simplification
>
> That would break the MacOS "force exit" thingy. Though sending a  
> signal
> to the signal handling threads so that it would then send a SIGABRT
> looks very convoluted to me. If you want to force exit, call exit 
> (), or
> otherwise _exit(), or otherwise abort(), or even raise(SIGKILL).  
> That's
> more straight-forward. And if the signal comes from outside, don't put
> it in the list of handled signals in the first place. Making VLC crash
> itself when the user press Ctrl+C was really wrong.

Thanks for pointing your change. I have just committed a fix that  
make "force quit" works again. This time deamon mode safe termination  
is preserved. Though I think we've better add someway to know that we  
are effectively in deamon mode before trapping SIGTERM (add a VLC  
command line option?).

Pierre.
-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html