[vlc-devel] Re: [PATCH] styled subtitles support
Jean-Baptiste Kempf
jb at videolan.org
Fri Mar 23 07:30:21 CET 2007
On Fri, Mar 23, 2007, Bernie Purcell wrote :
> Apologies in advance if multiple copies of this end up on the list. I've
> been trying to email this in for a few days now, and it never seems to
> come up in the list.
You don't have to excuse yourself. Our mail server and mailing-list
server has gone nuts. So lots of e-mails have not gone through it.
> This patch follows on to an earlier one I made that displayed USF
> subtitles in styled text. This one adds support for SubViewer (excluding
> the metadata header information for which I can't find a specification),
> MicroDVD, SubRip and VPlayer - ie. all the generics subtitle formats
> except SAMI.
> SAMI isn't straightforward, and the existing demux code strips out any
> tags which might have once been present in its context. It isn't a trivial
> job to pass the stylesheet information which can be contained in that
> format. A major hurdle in passing it lies in the fact that its XML is not
> well-formed.
> Because I couldn't find specs for any of these formats except SAMI (and
> ASS and USF) I made an executive decision to restrict the list of
> supported tags to the same ones used by Matroska in the USF DTD -- as
> explained in the comments in the code. If anyone has any corrections to
> apply to this assumption I'd like to hear from them, though.
> SSA/ASS is not included in this patch, but only because I haven't gotten
> around to it yet.
Ok. We will read the patch soon. This week end I guess.
Last patch was a very good quality patch, but we had to do a few modifications
(two leaks and one double free, IIRC) to make it perfect.
About ASS/SSA, those subtitles are complex since they need a lot of
things. Instead of reinveting once again the wheel, there is a summer of code
(and propositions) to integrate libass / asa or any other mean those
subtitles to VLC media player.
> This also contains some bugfixes on the earlier submission.
> Hopefully this time the patch will come out as ASCII instead of BINARY for
> Jean-Baptiste. :-)
I hope so too :D
Thanks;
--
Jean-Baptiste Kempf
http://www.jbkempf.com/
--
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
More information about the vlc-devel
mailing list