[vlc-devel] Re: vlc: svn commit r19407 (fenrir)

[Rémi Denis-Courmont]

Le samedi 24 mars 2007 19:03, Laurent Aimar a écrit :
> On Sat, Mar 24, 2007, Rémi Denis-Courmont wrote:
> > Le vendredi 23 mars 2007 21:59, Subversion daemon a écrit :
> > > r19407 | fenrir | 2007-03-23 20:59:11 +0100 (Fri, 23 Mar 2007) |
> > > 3 lines Changed paths:
> > >    M /trunk/src/input/control.c
> > >    M /trunk/src/input/input.c
> > >
> > > Extended INPUT_DEL_INFO (Allow deleting a whole category with
> > > NULL name) Fixed VLC_META_NOW_PLAYING update.
> >
> > This appears to contradict the prototype explicitly (null argument
> > where non-null required (argument 1)). Assuming the changeset is
> > correct, the prototype needs to be changed too.
>
>  Do you talk about :
>     src/input/input.c:257: warning: null argument where non-null
> required (argument 1) [...]
>  If so it's because vlc_meta_SetXXX( p_meta, NULL ) expands as
>   psz = NULL ? strdup(NULL) : NULL
>  and gcc warns about strdup(NULL)...

Regardless of the warning message, this macro is not expansion-safe. 
Better fix it, or use a static inline.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070324/741d5418/attachment.sig>