[vlc-devel] Re: vlc: svn commit r19402 (fenrir)

Laurent Aimar fenrir at via.ecp.fr
Sun Mar 25 00:54:19 CET 2007


On Sat, Mar 24, 2007, Rémi Denis-Courmont wrote:
> Le samedi 24 mars 2007 02:09, Laurent Aimar a écrit :
> > > I am not convinced this is correct at all. Which signals is causing
> > > a problem? polls are not supposed to be interrupted in the first
> > > place, or there is likely a bug somewhere else. Eating up a signal
> > > silently is plain wrong.
> >
> > Well from man poll:
> >
> > The poll() function will fail if:
> > [..]
> >      EINTR A signal was caught during the poll() function.
> 
> I did not say this cannot happen in the general case. But VLC blocks 
> signals it handles, so they cannot occur during poll() - or anything 
> else for that matter. The remaining ones will either crash the program 
> (so they poll won't have a chance to return) or be ignored (in which 
> case poll() ought not to be interrupted AFAIK).
 All ?
 SIGCHLD is currently not ignored and that's the one doing it
in my case (probably because system() is called by screensaver.c)
 Btw, ignoring SIGCHLD is not an option...
 So that leaves us with checking for EINTR every where we have to...

-- 
fenrir

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html



More information about the vlc-devel mailing list