[vlc-devel] Re: [PATCH] styled subtitles - warnings fixup

[Pierre d'Herbemont]

Hi Bernie,

On 29 mars 07, at 02:27, Bernie Purcell wrote:

> This patch (if the infernal thing works this time) should suppress the
> warnings generated when compiling freetype.c and subsdec.c - most of
> which came from new code I introduced.

> -#elif __APPLE__
> +#else
> + #ifdef __APPLE__

#elif defined(__APPLE__)
is easier to read.

> +                    *psz_text++ = '<';

Wouldn't it be proper to use unicode here? (just asking)

> +                            // Jump over unrecognised tag
Would be great to use a C++ style comment here.

> A final note about the code supplied, which allows most of the  
> subtitle
> formats to render HTML type output in the subtitles: it relies on
> Fontconfig. On OS X in particular this causes a problem, because the
> expectation is not only that VLC is compiled with it, but that the
> end-user has manually updated Fontconfig on their machine. I don't  
> think
> this is entriely practical, so have begun work on a Quartz-based
> subtitling engine for that platform. Am I duplicating anyone else's
> effort in doing this?

That would be cool!

Pierre.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070329/d5d563ae/attachment.html>