[vlc-devel] Re: [PATCH] styled subtitles - warnings fixup

[Derk-Jan Hartman]

On 30-mrt-2007, at 1:02, Bernie Purcell wrote:
> I've redone the patch with Pierre's changes to the __APPLE__ and  
> the C++
> comments included.
> Pierre - I'm not sure what you were getting at in regards to the  
> unicode
> comment. Can you explain? If you are asking why I am keeping the
> psz_html field of the filter struct as UTF-8 and not 16 or 32 bit
> unicode, it was firstly so as to keep as much of the RenderHtml  
> code the
> same as RenderText, to minimise any new bugs (and because I find the
> other unicode strings annoying to work with, with all those '\0'
> characters in the middle :-) ). It turns out now that I have an
> additional reason - the Quartz functions in a new module I'm trying to
> write all prefer their unicode strings in 16 bit unicode, not the  
> 32 bit
> unicode we use (everywhere?) in vlc - which means we'd only have to
> reformat it again on OS X. Does this answer your question, or am I
> trying to answer something else entirely?
>
> Bernie

patch applied.

> On Thu, 2007-03-29 at 11:28 +0200, Pierre d'Herbemont wrote:
>> Hi Bernie,
>>
>> On 29 mars 07, at 02:27, Bernie Purcell wrote:
>>
>>> This patch (if the infernal thing works this time) should suppress
>>> the
>>> warnings generated when compiling freetype.c and subsdec.c - most of
>>> which came from new code I introduced.
>>
>>
>>> -#elif __APPLE__
>>> +#else
>>> + #ifdef __APPLE__
>>
>>
>> #elif defined(__APPLE__)
>> is easier to read.
>>
>>
>>> +                    *psz_text++ = '<';
>>
>>
>> Wouldn't it be proper to use unicode here? (just asking)
>>
>>
>>> +                            // Jump over unrecognised tag
>> Would be great to use a C++ style comment here.
>>
>>
>>> A final note about the code supplied, which allows most of the
>>> subtitle
>>> formats to render HTML type output in the subtitles: it relies on
>>> Fontconfig. On OS X in particular this causes a problem, because the
>>> expectation is not only that VLC is compiled with it, but that the
>>> end-user has manually updated Fontconfig on their machine. I don't
>>> think
>>> this is entriely practical, so have begun work on a Quartz-based
>>> subtitling engine for that platform. Am I duplicating anyone else's
>>> effort in doing this?
>>
>>
>> That would be cool!
>>
>>
>> Pierre.
>>
>>
>>
>>
>> <noWarnings.svn-diff>

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html