[vlc-devel] Re: [PATCH] HW Pixel Doubling and Backlight-on for Maemo devices

[Jean-Paul Saman]

Hiltunen Tapio wrote:
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 20021)
> +++ configure.ac        (working copy)
> @@ -5578,6 +5578,16 @@
>  AC_LANG_POP(C++)
>  AM_CONDITIONAL(BUILD_MOZILLA,${mozilla})
>  
> +dnl Tests for Osso and Xsp
> +AC_CHECK_LIB(osso, osso_display_blanking_pause,[
> +   VLC_ADD_CPPFLAGS([x11],[-DHAVE_OSSO ${DBUS_CFLAGS} -I/usr/include/glib-2.0 -I/usr/include/glib-2.0/glib  -I/usr/lib/glib-2.0/include])

Can't we find a better way of knowing the include paths above? The way 
it is written now actually breaks cross-compiling. You should actually 
do something lie this (from old gtk configure check):

dnl     if test "${SYS}" != "mingw32"; then
dnl       VLC_ADD_CFLAGS([gtk],[`${GTK_CONFIG} --cflags gtk gthread`])
dnl       VLC_ADD_LDFLAGS([gtk],[`${GTK_CONFIG} --libs gtk gthread | sed 
's,-rdynamic,,'`])
dnl     else
dnl       VLC_ADD_CFLAGS([gtk],[`${GTK_CONFIG} --cflags gtk`])
dnl       VLC_ADD_LDFLAGS([gtk],[`${GTK_CONFIG} --libs gtk | sed 
's,-rdynamic,,'`])
dnl     fi
dnl

The fixed /usr/include/glib-2.0 need to change before this patch can be 
submitted.

Gtz,
Jean-Paul Saman

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html