[vlc-devel] Re: [PATCH] libdc1394 V2 updates for dc1394 access module

[Rob Shortt]

Andrea Guzzo wrote:
> At a first glance it seems really a good work to me ...

Thanks,

> I like the new api ... it's cleaner and less code is needed for both 
> scanning and initialization.
> 
> I think it's possible to support both apis with the same plugin ... 
> maybe this will make code a bit less readable ...
> but I can try to  clean my old one to make it more compact and to 
> isolate the version-specific blocks of code ...

Ok, it's worth a try to merge the two I guess.


> I like also the changes you made in process_options() ... and I'd like 
> to keep them in the merged module.....
> Actually I can test it only   with my isight firewire ... when I've done 
> here (I should find the time during this week), I'll send you the new 
> module sourcefile so you can test it with your camera before submitting 
> changes.

Sounds good.  I think those two cams are pretty much alike, maybe the 
isight supports more features though.

-Rob


-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html