[vlc-devel] Re: [PATH] qt4-interface to use media-keys and http-urls able to use usernames with @ in it

[Christophe Mutricy]

 Other patch changes that when seeking username/passwd in
> http-url it seeks last @ from url not first. This way username can
> contain @ itself eg. http://username@domain:passwd@some.where/

> Index: include/vlc_url.h
> ===================================================================
> --- include/vlc_url.h	(revision 20179)
> +++ include/vlc_url.h	(working copy)
> @@ -101,7 +101,7 @@
>          url->psz_protocol = psz_parse;
>          psz_parse = p;
>      }
> -    p = strchr( psz_parse, '@' );
> +    p = strrchr( psz_parse, '@' );
>      if( p != NULL )
>      {
>          /* We have a login */


That is wrong. According to RFC1738 , @ are possible in the rest of the
url  and '@', ':' and '/' in the user part should be encoded




-- 
Xtophe

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html