[vlc-devel] Re: vlc: svn commit r19398 (fenrir)

[Laurent Aimar]

On Fri, Mar 30, 2007, Derk-Jan Hartman wrote:
> On 23-mrt-2007, at 20:24, Subversion daemon wrote:
> >r19398 | fenrir | 2007-03-23 20:24:49 +0100 (Fri, 23 Mar 2007) | 5  
> >lines
> >Changed paths:
> >   M /trunk/modules/access/mms/mmsh.c
> >
> >Fixed #1102 ("Bad request" error)
> >Completed RESET command support.
> >Updated user agent to "NSPlayer/7.10.0.3059"
> 
> I was looking at this changeset, and suddenly noticed this in  
> GetPacket()
> 
>     else if( p_ck->i_type == 0x4324 )
>     {
>         /* 0x4324 is CHUNK_TYPE_RESET: a new stream will follow with  
> a sequence of 0 */
>         msg_Warn( p_access, "next stream following (reset) seq=%d",  
> p_ck->i_sequence  );
>         return VLC_EGENERIC;
>     }
> I'm wondering if with your changes to the code, this part in GetPacket 
> () is still correct.
 I think it is correct, 0x4324 is taken care of by Read when GetPacket return
an error (GetPacket was designed to report ok on data header or data packet).
 Did you see any new problem ?

-- 
fenrir

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html