[vlc-devel] Re: [PATCH] Matroska Attachments

[Steve Lhomme]

Jean-Baptiste Kempf wrote:
> Hello,
>
> On Wed, 30 May 2007 13:15:24 +1000, Bernie Purcell <b.purcell at adbglobal.com> wrote:
>   
>> This is part 1 of a breakup of a previous patch. It adds a mechanism to
>> retrieve the attachments from a Matroska container, using a demux
>> control message.
>>     
> Oki
>
>
>   
>> On Mon, 2007-05-28 at 20:28 +0200, Jean-Paul Saman wrote:
>>     
>>> What has attachement_t todo with the demuxer? I feel it is in the wrong
>>> headerfile.
>>>       
>> I don't know where else I could put it. It is a struct returned from a
>> container demuxer (ie. other container formats besides MKV support
>> attachments) and it is a control message to the demuxer that returns it.
>>     
>
> I think I understand the question now: "Is it used in other containers? What kinds?" 
>
> If there are other, then the patch is fine, if it is only used in mkv containers,
> then, leave it mkv headers.
>   

I think other containers might have attachment (cover of a CD in ID3 and 
M4A for example). But once thing after the other...

Steve

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html