[vlc-devel] vlc: svn commit r22950 (funman)

[Remi Denis-Courmont]

On Mon,  5 Nov 2007 00:42:06 +0100 (CET), Subversion daemon
<svn at videolan.org> wrote:
> r22950 | funman | 2007-11-05 00:42:06 +0100 (Mon, 05 Nov 2007) | 3 lines
> Changed paths:
>    M /trunk/modules/misc/screensaver.c
> 
> screensaver: replaces system() calls by fork()/execv()/waitpid()
> A side effect is that on FreeBSD the console is not filled anymore with
> "xscreensaver-xxx not found", because "/bin/sh xx 2>&-" will not close
> stderr if the specified command doesn't exist.


That is very ugly. Closing stdout and stderr is wrong.
You should probably freopen("/dev/null", "w", {stdout, stderr}) instead.