[vlc-devel] Real Video Decoding....

Jean-Baptiste Kempf jb at videolan.org
Tue Nov 6 07:01:31 CET 2007


Here attached is a patch that lied in the forum, made by a chinese guy.

The modifications I made are minimal.

Here are my first remarks on the patch.

1) In the
static int load_syms_linux function
* l.157, it should return 0 and not NULL.
* l.168 it shouldn't return a void* in a int function

Or maybe the function should just be of a void* type.

2. Line 218, it calls 'load_syms' which is just defined on windows and 
not linux. So the #ifdef WIN32 are wrongly placed.

3. l.93 is useless.

4. rvyuv_hive_message is useless (l.83) and probably the windows 
contrepart of the function too.

5. patch is attached :D

Have a nice day. 'coin coin'


-------------- next part --------------
A non-text attachment was scrubbed...
Name: RV.patch
Type: text/x-patch
Size: 148796 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20071105/03670bb1/attachment.bin>

More information about the vlc-devel mailing list