[vlc-devel] Macros & IDE

[Rémi Denis-Courmont]

Le Sunday 25 November 2007 19:54:03 Pierre d'Herbemont, vous avez écrit :
> On Nov 25, 2007, at 10:40 AM, Jean-Paul Saman wrote:
> > Jean-Baptiste Kempf wrote:
> >> On Sun, Nov 25, 2007, Guy Paddock wrote :
> >>> Quick question: why does the VLC source use macros so much? I
> >>> mean, I
> >>> understand their use for ensuring unique function names in case
> >>> modules are compiled-in or built separately, but IMO they seem to be
> >>> overused. Personally, I like to avoid macros like the plague because
> >>> they're not context-safe, but that's just me.
>
> To me;,there are clearly some macro abuses in VLC. Feel free to clean
> them.
> However some macro uses are legitimate and needed, especially to
> implement VLC's object abstraction.

That's for sure. Some macros are overly large for macros (-> code size). Also 
in many cases, using static inlines would be safer (but that does not fix the 
code size issue).

-- 
Rémi Denis-Courmont
http://www.remlab.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20071125/cd3a1ba6/attachment.sig>