[vlc-devel] vlc: svn commit r23372 (ileoo)

[Remi Denis-Courmont]

On Tue, 27 Nov 2007 13:43:54 +0100 (CET), Subversion daemon
<svn at videolan.org> wrote:
> r23372 | ileoo | 2007-11-27 13:43:54 +0100 (Tue, 27 Nov 2007) | 2 lines
> Changed paths:
>    M /trunk/modules/access/file.c
> 
> oneliner to fix i_pos updating. works for me.

I think that's wrong. mmap() fetches <length> bytes
starting from <offset>. Hence the new position has got
to be offset + length, right?

Incrementing i_pos by length bytes will fail if,
for any reasons, the original i_pos is not a multiple of
the page size. This can happen if Seek() has been used, or
if the file size has increased while we were reading it.
-- 
Rémi.