[vlc-devel] Patch for playlist on Mac OS X

[John Dalgliesh]

Hi,

I just downloaded and built VLC from svn on Mac OS X. It crashed when 
attempting to play anything. Recent nightlies also crash. I found the bug 
and fixed it in the attached patch.

The problem was that too few arguments were passed to the vararg function 
playlist_Control with the PLAYLIST_VIEWPLAY selector. Garbage was then 
read off the stack and stored away for crashing with later :)

It seems to have been introduced with other changes in r21230:
------------------------------------------------------------------------
r21230 | fkuehne | 2007-08-19 04:59:42 +1000 (Sun, 19 Aug 2007) | 1 line

* fixed a few unknown playlist queries
------------------------------------------------------------------------

I have reverted to the previous behaviour for the affected calls.

This is my first post to this list. Please excuse me if my post or patch 
are out of line.

{P^/
1/10/2007
John Dalgliesh
-------------- next part --------------
Index: modules/gui/macosx/playlist.m
===================================================================
--- modules/gui/macosx/playlist.m	(revision 22347)
+++ modules/gui/macosx/playlist.m	(working copy)
@@ -1046,7 +1046,7 @@
         {
             playlist_item_t *p_item;
             p_item = playlist_ItemGetByInput( p_playlist, p_input, VLC_TRUE );
-            playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, VLC_TRUE, p_item );
+            playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, VLC_TRUE, NULL, p_item );
         }
         else
         {
@@ -1088,7 +1088,7 @@
         {
             playlist_item_t *p_item;
             p_item = playlist_ItemGetByInput( p_playlist, p_input, VLC_TRUE );
-            playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, VLC_TRUE, p_item );
+            playlist_Control( p_playlist, PLAYLIST_VIEWPLAY, VLC_TRUE, NULL, p_item );
         }
         else
         {