[vlc-devel] vlc: svn commit r22410 (funman)

Laurent Aimar fenrir at via.ecp.fr
Wed Oct 3 23:54:51 CEST 2007

On Wed, Oct 03, 2007, Subversion daemon wrote:
> r22410 | funman | 2007-10-03 21:29:49 +0200 (Wed, 03 Oct 2007) | 2 lines
> Changed paths:
>    M /trunk/modules/codec/ffmpeg/demux.c
>    M /trunk/modules/demux/flac.c
>    M /trunk/modules/demux/mpc.c
>    M /trunk/modules/demux/mpeg/m4a.c
>    M /trunk/modules/demux/mpeg/mpga.c
>    M /trunk/modules/demux/ogg.c
>    M /trunk/modules/demux/tta.c
> Demuxers: do not load "meta reader" module if the input item has already been preparsed.
 Please revert this commit.

 A demuxer should NEVER do such thing like
  vlc_object_find( p_demux, VLC_OBJECT_INPUT, FIND_PARENT ); 
(I agree that sometimes it is complicated, but in this case it is not)

 Beside using input_GetItem on p_input at such place can be
dangerous (A demuxer can run in it's own thread ...)

 Now, it is really time consuming to do it every time the file is played ?

If yes, well we can just add a vlc variable "input-preparsed" and just do

 if( !var_GetBoolean( p_demux, "input-preparsed" ) )
instead of all the mess.
("input-preparsed" will be created by src/input)


More information about the vlc-devel mailing list