[vlc-devel] vlc: svn commit r22410 (funman)

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Laurent Aimar a écrit :
> On Wed, Oct 03, 2007, Subversion daemon wrote:
>> r22410 | funman | 2007-10-03 21:29:49 +0200 (Wed, 03 Oct 2007) | 2 lines
>> Changed paths:
>>    M /trunk/modules/codec/ffmpeg/demux.c
>>    M /trunk/modules/demux/flac.c
>>    M /trunk/modules/demux/mpc.c
>>    M /trunk/modules/demux/mpeg/m4a.c
>>    M /trunk/modules/demux/mpeg/mpga.c
>>    M /trunk/modules/demux/ogg.c
>>    M /trunk/modules/demux/tta.c
>>
>> Demuxers: do not load "meta reader" module if the input item has already been preparsed.
>  Please revert this commit.
> 
>  A demuxer should NEVER do such thing like
>   vlc_object_find( p_demux, VLC_OBJECT_INPUT, FIND_PARENT ); 
> (I agree that sometimes it is complicated, but in this case it is not)

Ok, is the reason that vlc_object_find() must be used with parsimony ?

>  Beside using input_GetItem on p_input at such place can be
> dangerous (A demuxer can run in it's own thread ...)

I should have locked it :/

>  Now, it is really time consuming to do it every time the file is played ?

I didn't run performance tests, but I just thought it was useless.

> If yes, well we can just add a vlc variable "input-preparsed" and just do
> 
>  if( !var_GetBoolean( p_demux, "input-preparsed" ) )
>  {
>   xyz;
>  }
> instead of all the mess.
> ("input-preparsed" will be created by src/input)

Ok, I saw you created that variable in [22415], now it should be
inherited from the input by the demuxer, true ?

- --
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHBBpjYWCeGMCv8Q8RAjVbAKDW1/f1yqOqRusSsog9aiYukm32vACfTarB
ezUy7Q2r6YzCRFUpOnRwySk=
=KQ9z
-----END PGP SIGNATURE-----