[vlc-devel] vlc: svn commit r22410 (funman)

Rafaël Carré funman at videolan.org
Thu Oct 4 01:51:25 CEST 2007

Hash: SHA1

Laurent Aimar a écrit :
> On Thu, Oct 04, 2007, Rafaël Carré wrote:
>> Ok, is the reason that vlc_object_find() must be used with parsimony ?
>  That is one, yes.
>  Plus you create a extra uneeded dependency between demux and input.
> (Less clean/more difficult to maintain in the long term)

That sounds good.

>>>  Now, it is really time consuming to do it every time the file is played ?
>> I didn't run performance tests, but I just thought it was useless.
>  Ok.

Well I suppose that with your clever solution to use variables, it's not
comparable to file opening, file reading, file closing.

Maybe that's not a real gain, but that will look much cleaner.

>> Ok, I saw you created that variable in [22415], now it should be
>> inherited from the input by the demuxer, true ?
>  Yes, it is automatic (with var_CreateGetTYPE). If you could verify that
> it works, that would be great.

That works, and it seems that if for any reason the variable was not
created when the demuxer is closed, var_Destroy() will do nothing
harmful, so I'm converting the demuxers to that solution.

Thanks for your help !

- --
Rafaël Carré
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


More information about the vlc-devel mailing list