[vlc-devel] [RFC] input & metadata
funman at videolan.org
Mon Oct 8 21:02:39 CEST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Laurent Aimar a écrit :
> On Mon, Oct 08, 2007, Rafaël Carré wrote:
>>> I will add a DEMUX_HAS_UNSUPPORTED_META (demux2_Control) that will
>>> return TRUE if a demuxer know that the file can have meta data but
>>> does not support it.
>>> Then the input will take care of calling a meta-reader plugin.
>>> That will remove a lot of duplicate code. (Of course it will also support
>>> attachment read from the meta-reader).
>>> If you do not see any problem, I will commit the changes tomorrow.
>> That sounds better indeed.
> It is done. mpc/mp3/m4a/ac3/ogg/flac now use this facility.
> Do you see any other file format that can have id3/ap2 tags ?
Not at all, i'm fine with these formats.
>> Maybe DEMUX_HAS_NO_META is a better name ?
> Not really, the file has(may have) meta data, it is just that the demuxer
> does not bother reading them itself.
Like flac, just figured.
Thanks for your change, I'll be happy to test and report if I find
problems with it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the vlc-devel