[vlc-devel] vlc: svn commit r22460 (damienf)

[Damien Fouilleul]

Rémi Denis-Courmont wrote:
> Le Monday 08 October 2007 23:10:41 Damien Fouilleul, vous avez écrit :
>   
>> yes, i agree, i dunno really why these were in headers in the first
>> place, but i felt lazy and i only really put the minimum effort into
>> that one, but by implementing this function i got a bit dazzled about
>> the state of the existing thread code for win32, sounds awfully
>> complicated for what it does, it sounds to me that it does more than it
>> should. when I have time I'll review that code properly and take it out
>> the headers all together.
>>
>> actually, i'm thinking off taking it out altogether and wrap the
>> existing calls to pthread-win32 instead
>>
>> anyone has a strong opinion on this ?
>>     
>
> I already suggested this over a year ago.
>
> But at the time, Gibalou was THE VLC win32 guy, and he thought that 
> pthread-win32 had bad performance footprint. Figure - either of you would 
> know better than me anyway.
>
>   
well, i think he was right back then, in order to be compliant, 
pthreads-win32 needs to do more work that what the VLC wrapper code is 
doing, but I'm not really sure if this really matters on nowadays CPUs. 
it probably did on a pentium III.

Damien