[vlc-devel] [PATCH] Update ty support to include TiVo Series 2

[Jean-Baptiste Kempf]

On Thu, Oct 11, 2007, Dave Still wrote :
> Sorry if this goes to the list twice, but my mail server went down  
> just as I was sending this.  It hasn't shown up in my mailbox or in  
> the archives, so I'm assuming that the original got lost in the ether.
No, it came correctly.

> I just discovered that the first patch was bad.  Trying to apply it  
> will give you a "patch is malformed" type of error.  Attached is a  
> new patch that applies cleanly.
Yes, this patch applies cleanly now.

However, I am not the one to make any comments on the code, but you have
tabs and trailing spaces in your patch ( that is bad! (tm) :D )

Anyway, you may want to send those patches in non gziped format.

The code has some compiling issues and warnings:
../../../include/vlc_input.h: In function 'input_item_MetaMatch':
../../../include/vlc_input.h:247: warning: implicit declaration of
function 'strcasestr'
../../../modules/demux/ty.c: In function 'ty_stream_seek_time':
../../../modules/demux/ty.c:951: warning: comparison between signed and
unsigned
../../../modules/demux/ty.c:981: warning: comparison between signed and
unsigned
../../../modules/demux/ty.c: In function 'parse_master':
../../../modules/demux/ty.c:1104: warning: format '%02d' expects type
'int', but argument 6 has type 'long int'
../../../modules/demux/ty.c:1104: warning: format '%02d' expects type
'int', but argument 7 has type 'long int'
../../../modules/demux/ty.c:1104: warning: format '%02d' expects type
'int', but argument 8 has type 'long int'
../../../modules/demux/ty.c:1107: warning: format '%02d' expects type
'int', but argument 6 has type 'long int'
../../../modules/demux/ty.c:1107: warning: format '%02d' expects type
'int', but argument 7 has type 'long int'
../../../modules/demux/ty.c:1107: warning: format '%02d' expects type
'int', but argument 8 has type 'long int'
../../../modules/demux/ty.c: In function 'Control':
../../../modules/demux/ty.c:1129: warning: cast from function call of
type 'int64_t' to non-matching type 'double'
../../../modules/demux/ty.c: In function 'probe_stream':
../../../modules/demux/ty.c:1188: warning: passing argument 2 of
'stream_Peek' from incompatible pointer type
../../../modules/demux/ty.c: In function 'analyze_chunk':
../../../modules/demux/ty.c:1246: warning: pointer targets in passing
argument 4 of 'parse_chunk_headers' differ in signedness
../../../modules/demux/ty.c: In function 'get_chunk_header':
../../../modules/demux/ty.c:1351: warning: passing argument 2 of
'stream_Peek' from incompatible pointer type

Could you look at them?

> Who can I speak to about getting this patch applied to the current  
> build?  Currently TiVo Series 2 users have to either build the module  
> from source themselves or wait for someone else to post a module for  
> their platform in the Deal Database forums (here's the support  
> thread: http://dealdatabase.com/forum/showthread.php?t=42332 ).  It  
> would be great if we could get these changes rolled into the current  
> build.  Any comments about the patch would be greatly appreciated.

fenrir ? :D

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/