[vlc-devel] [PATCH] $HOME envvar should be checked before getpwuid()

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Benjamin Cama a écrit :
> Hi,
> 
> VLC behavior concerning where to look for user's home directory is a bit
> broken (it killed my afternoon ...) : it should check $HOME before going
> getpwuid (see man getpwuid). This patch corrects this, checking in this
> order :
> $HOME -> getpwuid() -> $TMP -> /tmp
> (before was getpwuid() -> $HOME -> $TMP -> /tmp)
> 
> It was also not tested ....
> Please CC me for any anwser, as i'm not subscribed.
> 
> Regards,
> Benjamin

Committed, thanks.

Note that the english man page doesn't talk about HOME, opposed to the
french man page.

I suppose french man page is a translation of
http://kerneltrap.org/man/linux/man3/getpwuid.3 .

And the english man page comes from
http://www.opengroup.org/onlinepubs/007908799/xsh/getpwuid.html which
should be considered as the "official" man page.

But we can consider it's safe to rely on $HOME first before anything else ;)

- --
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHE2abYWCeGMCv8Q8RAix7AJ9dVhLtTGGxmE5JScCprHIC9frtQwCeJvCH
qv43TnNIH3EsWrdRi3usTeY=
=fcBt
-----END PGP SIGNATURE-----