[vlc-devel] vlc: svn commit r22621 (funman)

Jean-Baptiste Kempf jb at videolan.org
Tue Oct 16 00:20:26 CEST 2007

On Mon, Oct 15, 2007, Subversion daemon wrote :
> r22621 | funman | 2007-10-15 23:09:40 +0200 (Mon, 15 Oct 2007) | 1 line
> Changed paths:
>    M /trunk/modules/gui/qt4/components/preferences_widgets.cpp
>    M /trunk/modules/gui/qt4/components/simple_preferences.cpp
>    M /trunk/modules/gui/qt4/components/simple_preferences.hpp
>    M /trunk/modules/gui/qt4/ui/sprefs_audio.ui
> qt4 simple preferences: only show the options of the selected audio output module

You should use a QStackedLayout and a QCombobox + QVariant.

This commits add too much connects and too many tests that could be

Moreover you should use Module_Exists because everyone hasn't OSS + Alsa
on linux, for example...

So for once, I am not too fond about this commit.

Jean-Baptiste Kempf

More information about the vlc-devel mailing list