[vlc-devel] vlc: svn commit r22784 (funman)

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Rémi Denis-Courmont a écrit :
> Le Monday 22 October 2007 05:01:59 Subversion daemon, vous avez écrit :
>> r22784 | funman | 2007-10-22 04:01:55 +0200 (Mon, 22 Oct 2007) | 4 lines
>> Changed paths:
>>    M /trunk/include/vlc_configuration.h
>>    M /trunk/modules/gui/qt4/components/simple_preferences.cpp
>>
>> configuration: add config_AddIntf() config_RemoveIntf() and
>> config_ExistIntf() to handle extra interfaces in the preferences make use
>> of it for last.fm simple preferences (ref #1262)
>> by the way the duplication of "control" with "extraintf" is very boring
> 
> Please. Don't put such big functions into header files. Couldn't you see the 
> warnings emitted by GCC (declared but not used) in just about every VLC file?
> 

I don't know where I could put those since they are likely to be reused
by MacOSX interface.

inlining them removes the warning, but that still leaves big functions
inside the header, I thought that wouldn't be a problem seeing vlc_input.h

- --
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHHOahYWCeGMCv8Q8RAnjiAKC47W+xGyDnBDLhh9s068c7lefiYACfXieg
duf6wdKW4NYsV/i8mu2bS7c=
=3/7K
-----END PGP SIGNATURE-----