[vlc-devel] vlc: svn commit r22812 (funman)

[Rémi Denis-Courmont]

On Tue, 23 Oct 2007 14:10:31 +0200 (CEST), Subversion daemon
<svn at videolan.org> wrote:
> r22812 | funman | 2007-10-23 14:10:30 +0200 (Tue, 23 Oct 2007) | 4 lines
> Changed paths:
>    M /trunk/modules/control/dbus.c
> 
> dbus: don't lock the playlist, but only yield the input to prevent its
> destruction while we are accessing it.
> We do that because we can't lock the playlist when we're in the input
> "state" callback because we MAY have been called by playlist_Control(),
> which does lock the playlist, and then call us.
> ref #1346

I don't quite understand that one.
Why:
0/ get input from playlist
...
1/ vlc_object_yield(input)
2/ var_Get(input)
3/ vlc_object_release(input) ???

If the input cannot be destroyed between 0 and 1, why could it get
destroyed between 1 and 3? And, if it can be destroyed between 0
and 1, then you are screwed - vlc_object_yield will crash instead
of var_Get.

-- 
Rémi Denis-Courmont
http://www.remlab.net/