[vlc-devel] vlc: svn commit r22914 (funman)

Rémi Denis-Courmont rdenis at simphalempin.com
Wed Oct 31 08:07:52 CET 2007


On Wed, 31 Oct 2007 03:51:24 +0100 (CET), Subversion daemon
<svn at videolan.org> wrote:
> r22914 | funman | 2007-10-31 03:51:23 +0100 (Wed, 31 Oct 2007) | 1 line
> Changed paths:
>    M /trunk/src/vlc.c
> 
> Yes, sigwait() can fail, so don't ignore its return value

>From Linux documentation:

"The !sigwait! function never returns an error."

>From the more authoritative POSIX documentation:

"The sigwait() function may fail if:
    [EINVAL]
        The set argument contains an invalid or unsupported signal number."

which can never happen in our case. This commit is just plain wrong.

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list