[vlc-devel] Current extras/contrib faac patch broken -- needsLF only, at least under Cygwin

[Mark Moriarty]

I get exactly the same failure as you, just that it's the SVN copy of the
file that fails -- a mirror image. 

The question, to me, is why do we both get a failure in that same area of
patch code, yet both (I assume) get other patches applying OK?  What really
bites is that only:
diff -Nur live.orig/config.cygwin live/config.cygwin
--- live.orig/config.cygwin	2007-08-03 18:38:58.000000000 +0200
+++ live/config.cygwin	2007-09-17 01:49:49.000000000 +0200
@@ -1,4 +1,4 @@
-COMPILE_OPTS =		$(INCLUDES) -I. -O -DSOCKLEN_T=socklen_t
+COMPILE_OPTS =		$(INCLUDES) -I. -O -DSOCKLEN_T=socklen_t
-DUSE_SYSTEM_RANDOM=1
 C =			c
 C_COMPILER =		gcc
 C_FLAGS =		$(COMPILE_OPTS) -DUSE_OUR_BZERO=1 -D__CYGWIN__

Seems to apply to cygwin in any way, but it does apply, so the file should
be one that actually is able to build on Cygwin.

I see no errors in applying any of the other live patches, only that one
file "burps".

Separately, I'm still running into x264 build issues -- those "AR = $(AR)"
type lines just aren't working, so I get the 
nasm -O2 -f win32 -DPREFIX -Icommon/i386/ -o common/i386/dct-a.o
common/i386/dct
-a.asm
make[3]: x: Command not found
make[3]: [common/i386/dct-a.o] Error 127 (ignored)
nasm -O2 -f win32 -DPREFIX -Icommon/i386/ -o common/i386/cpu-a.o
common/i386/cpu
-a.asm
make[3]: x: Command not found
make[3]: [common/i386/cpu-a.o] Error 127 (ignored)
Set of errors, then the 

make[3]: [common/i386/deblock-a.o] Error 127 (ignored)
rc libx264.a common/mc.o common/predict.o common/pixel.o common/macroblock.o
com...
make[3]: rc: Command not found
make[3]: *** [libx264.a] Error 127
make[3]: Leaving directory `/home/mfm/vlc-trunk/extras/contrib/src/x264'
make[2]: *** [.x264] Error 2

If I go into the x264 win32 patch, change the $(AR), $(RANLIB), $(STRIP)
back to AR, RANLIB, STRIP (at lines 26, 27, and 36 of the patch file), I
seem to get through that "bump" OK, but it fails on a pthread-related item:
RANLIB libx264.a
gcc -mno-cygwin -isystem /usr/include/mingw -o x264.exe x264.o matroska.o
muxers
.o libx264.a -L/home/mfm/vlc-trunk/extras/contrib/lib -mno-cygwin
-mno-cygwin -l
pthread -lvfw32 -s
libx264.a(cpu.o):cpu.c:(.text+0x192): undefined reference to
`__imp__pthread_num
_processors_np'
collect2: ld returned 1 exit status
make[3]: *** [x264.exe] Error 1

By any chance, do you know what AROPTS is, and where it would be invoked?.
Given that the AR, STRIP, and RANLIB statements (lines 9, 10, 12) were all
breaking, I half expect that AROPTS = $(AROPTS) (line 11) is also having
issues.

Otherwise, is there an actual documented, working, msys configuration?  I
really have nothing against it, just that I couldn't get it to install and
work with VLC, at all.

Thanks!