[vlc-devel] commit: VLCKit.framework: Remove dead code from VLCTime object. ( Faustino Osuna )

git version control git at videolan.org
Tue Apr 1 01:00:21 CEST 2008


vlc | branch: master | Faustino Osuna <enrique.osuna at gmail.com> | Mon Mar 31 23:57:19 2008 +0100| [f87ebe5bfc9ad2842bc428a04d458f95183c300c]

VLCKit.framework: Remove dead code from VLCTime object.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f87ebe5bfc9ad2842bc428a04d458f95183c300c
---

 projects/macosx/framework/Headers/Public/VLCTime.h |    2 -
 projects/macosx/framework/Sources/VLCTime.m        |   31 ++++++--------------
 2 files changed, 9 insertions(+), 24 deletions(-)

diff --git a/projects/macosx/framework/Headers/Public/VLCTime.h b/projects/macosx/framework/Headers/Public/VLCTime.h
index 61a53a0..6ebac8b 100644
--- a/projects/macosx/framework/Headers/Public/VLCTime.h
+++ b/projects/macosx/framework/Headers/Public/VLCTime.h
@@ -35,11 +35,9 @@
 /* Factories */
 + (VLCTime *)nullTime;
 + (VLCTime *)timeWithNumber:(NSNumber *)aNumber;
-//+ (VLCTime *)timeWithString:(NSString *)aString;
 
 /* Initializers */
 - (id)initWithNumber:(NSNumber *)aNumber;
-//- (id)initWithString:(NSString *)aString;
 
 /* Properties */
 @property (readonly) NSNumber * numberValue;
diff --git a/projects/macosx/framework/Sources/VLCTime.m b/projects/macosx/framework/Sources/VLCTime.m
index 566d94b..d79fa06 100644
--- a/projects/macosx/framework/Sources/VLCTime.m
+++ b/projects/macosx/framework/Sources/VLCTime.m
@@ -25,6 +25,7 @@
 #import <VLCTime.h>
 
 @implementation VLCTime
+/* Factories */
 + (VLCTime *)nullTime
 {
     static VLCTime * nullTime = nil;
@@ -38,12 +39,7 @@
     return [[[VLCTime alloc] initWithNumber:aNumber] autorelease];
 }
 
-// TODO: Implement [VLCTime timeWithString]
-//+ (VLCTime *)timeWithString:(NSString *)aString
-//{
-//  return [[[VLCTime alloc] initWithString:aString] autorelease];
-//}
-
+/* Initializers */
 - (id)initWithNumber:(NSNumber *)aNumber
 {
     if (self = [super init])
@@ -56,23 +52,19 @@
     return self;
 }
 
-// TODO: Implement [VLCTime initWithString]
-//- (id)initWithString:(NSString *)aString
-//{
-//  // Sounds like a good idea but I really don't think there is any value added
-//  if (self = [super init])
-//  {
-//      // convert value
-//  }
-//  return self;
-//}
-
 - (void)dealloc
 {
     [value release];
     [super dealloc];
 }
 
+/* NSObject Overrides */
+- (NSString *)description
+{
+    return self.stringValue;
+}
+
+/* Operations */
 - (NSNumber *)numberValue
 {
     return value ? [[value copy] autorelease] : nil;
@@ -104,9 +96,4 @@
     else
         return [value compare:aTime.numberValue];
 }
-
-- (NSString *)description
-{
-    return self.stringValue;
-}
 @end




More information about the vlc-devel mailing list