[vlc-devel] commit: test code cleanup (Filippo Carone )

Pierre d'Herbemont pdherbemont at free.fr
Tue Apr 1 09:26:10 CEST 2008

On Apr 1, 2008, at 7:33 AM, Remi Denis-Courmont wrote:

> On Tue, 1 Apr 2008 01:02:10 +0200, Pierre d'Herbemont <pdherbemont at free.fr 
> >
> wrote:
>>> +    sleep(1); // play is asynchronous
>> We tend to prefer /* */ comment in C code...
> For a certain definition of we.

Hum. Definitely yes. Read I.

> "C++-style" // comments are specified in ISO C99. And even older  
> compilers
> (which probably can't build VLC, but nevermind) tend to allow these
> comments as an extension due to supporting C++.

Crazy me. But I think that // comment are bad. Don't worry, I am  
certainly wrong, old, and conservator. So it's not about what C allows  
to do.

In the other end, that allows to keep a certain uniformity in VLC  
code. Also, I was remembering that we more or less did settle that  
we'd better try to use the same commenting style across files.

Anyway, that's certainly a dummy rule of I, yet, I don't see much //  
comment in commit, and when I see one I usually jump... Must have been  
a long time since someone break this implicit rule then... In fact I  
really did forgot we had this discussion.

> I wonder how many times I am going to have to re-re-repeat this again.

 From times to times it never hurts, it keeps the vlc-devel alive :p

Or you'll have to regularly checkin // comment in C code so that I can  
accustoms myself ;)


More information about the vlc-devel mailing list