[vlc-devel] commit: Don't leak memory. (Jean-Paul Saman )

git version control git at videolan.org
Wed Apr 9 12:44:50 CEST 2008


vlc | branch: master | Jean-Paul Saman <jean-paul.saman at m2x.nl> | Wed Apr  9 12:41:50 2008 +0200| [2357ced8cd030854a8215ed03da6cf316d201b1f]

Don't leak memory.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2357ced8cd030854a8215ed03da6cf316d201b1f
---

 .../video_filter/dynamicoverlay/dynamicoverlay.c   |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/modules/video_filter/dynamicoverlay/dynamicoverlay.c b/modules/video_filter/dynamicoverlay/dynamicoverlay.c
index 4f701a0..cee5c5c 100644
--- a/modules/video_filter/dynamicoverlay/dynamicoverlay.c
+++ b/modules/video_filter/dynamicoverlay/dynamicoverlay.c
@@ -368,8 +368,9 @@ static subpicture_t *Filter( filter_t *p_filter, mtime_t date )
                 *pp_region = NULL;
                 break;
             }
-            (*pp_region)->psz_text = strdup( p_overlay->data.p_text );
-            memcpy( (*pp_region)->p_style, &p_overlay->fontstyle, sizeof(text_style_t) );
+            p_filter->p_libvlc->pf_memcpy( (*pp_region)->p_style,
+                                            &p_overlay->fontstyle,
+                                            sizeof(struct text_style_t) );
         }
         else
         {




More information about the vlc-devel mailing list