[vlc-devel] [Patch] fix for VolumeBar in Toolbar, compatible to wxwidgets 2.8 (fixed)
dominique at leuenberger.net
Sat Apr 12 09:45:15 CEST 2008
Quoting Dominique Leuenberger <dominique at leuenberger.net>:
> Quoting Dominique Leuenberger <dominique at leuenberger.net>:
>> As you know, when compiling vlc 0.8.6 and also 0.9.0 against
>> wxwidgets 2.8, the volume bar and the speaker icon in the toolbar
>> are mis-aligned.
>> Together with the wxwidgets team we found that there seems to be a
>> problem when positioning custom controls in the toolbar. The
>> solution was to get rid of the customn control (which was just a
>> combination of a bmp tool and a wxGauge) and put the two objects
>> independent in the toolbar.
>> There patch strips out the VLCVolCtrl Class (no longer needed) and
>> places a bmp tool and a wxSlider in the Toolbar (I replaced the
>> wxGauge; wxSlider is actually more what correct for this use case,
>> and in plus, wxGauge does not have any Events, as it's meant as an
>> 'output' only.
>> When the slider is moved completely to the left, the speaker bmp is
>> changed to speaker_mute_xpm.
>> The patch is for 0.8.6f, I'll work on a patch for 0.9.0 today.. I
>> assume there should not be much differences, considering the fact
>> that not much changes were done on wxwidgets for 0.9.0, due to
>> missing maintainer.
>> Maybe this patch could go in a upcoming 0.8.6x version tree (should
>> there be any). (I did not yet test the patch against wxwidgets
>> 2.6, but considering that there are only standard widgets used,
>> this should not be to much of an issue, (praying for it)
just out of curiosity: is there something missing for this patch or
did it get 'lost'?
The segfaults that were mentioned earlier are not caused by this
patch: I see it happening as often with as without the patch; I think
it's more likely an issue in another, underlying library (not even wx
So the patch in itself is not a problem at all and does not cause any
issues (that I would be aware of).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: PGP Digital Signature
More information about the vlc-devel