[vlc-devel] [RFC] Regarding the use of *_Control()

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Mon, 14 Apr 2008 16:49:39 +0200,
Pierre d'Herbemont <pdherbemont at free.fr> a écrit :

> 
> On Apr 14, 2008, at 4:40 PM, Antoine Cellerier wrote:
> >>> Well, of course, that's the main advantage of *_Control(). But
> >>> given that we nearly never add callbacks, the ABI would rarely
> >>> change.
> >>                 ^^^^^
> >> Must be a typo. We've been adding items at about every releases,  
> >> access
> >> content-type being the most recent one.
> 
> I wasn't aware of that one.
> 
> > On Mon, Apr 14, 2008, R?mi Denis-Courmont wrote:
> >>> An other possibility is to maintain a separate private structure
> >>> for the callback. Hence adding a callback won't break the ABI.
> >>> That would
> >>> be nicer.
> >>>
> > Agreed :)
> 
> Well, to me clean up are always nice, even if it requires work. But  
> let's drop it for now.
> 
> Does "no answer" means that we are ok with the first part which is  
> about privatizing the _Control() calls?

Not really.

I would prefer you to post the patch here so I can complain on a real
exemple before pushing to the tree.

- -- 
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIA3+PYWCeGMCv8Q8RAg0rAKDWA0udz7Mpqjc8xORznwY17MXTBgCg0pGX
iYDYvMEypT0yi5Yrmc7b6YA=
=DVa0
-----END PGP SIGNATURE-----