[vlc-devel] commit: fixed misc/stats.c:399: warning: comparison between signed and unsigned in function '__stats_TimerClean' ( Michael Ploujnikov )

[git version control]

vlc | branch: master | Michael Ploujnikov <ploujj at gmail.com> | Wed Apr 16 21:21:33 2008 -0400| [47240a152bd03e4775f265c9c5ed8fe73e90ddee]

fixed misc/stats.c:399: warning: comparison between signed and unsigned in function '__stats_TimerClean'

Based on usage of i_id, other stats_* functions and my opinion i_id should be unsigned int instead of int, but I might be missing the bigger picture related to changing public APIs. Please, let me know how to correctly deal with such warnings.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=47240a152bd03e4775f265c9c5ed8fe73e90ddee
---

 include/vlc_messages.h |    2 +-
 src/misc/stats.c       |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/vlc_messages.h b/include/vlc_messages.h
index d8b7b38..113825c 100644
--- a/include/vlc_messages.h
+++ b/include/vlc_messages.h
@@ -377,6 +377,6 @@ VLC_EXPORT( void,__stats_TimersDumpAll, (vlc_object_t*) );
 VLC_EXPORT( void, __stats_TimersCleanAll, (vlc_object_t * ) );
 
 #define stats_TimerClean(a,b) __stats_TimerClean( VLC_OBJECT(a), b )
-VLC_EXPORT( void, __stats_TimerClean, (vlc_object_t *, int ) );
+VLC_EXPORT( void, __stats_TimerClean, (vlc_object_t *, unsigned int ) );
 
 #endif
diff --git a/src/misc/stats.c b/src/misc/stats.c
index 7e967f9..191dc82 100644
--- a/src/misc/stats.c
+++ b/src/misc/stats.c
@@ -389,7 +389,7 @@ void __stats_TimersDumpAll( vlc_object_t *p_obj )
     vlc_mutex_unlock( &p_obj->p_libvlc->timer_lock );
 }
 
-void __stats_TimerClean( vlc_object_t *p_obj, int i_id )
+void __stats_TimerClean( vlc_object_t *p_obj, unsigned int i_id )
 {
     int i;
     vlc_mutex_lock( &p_obj->p_libvlc->timer_lock );