[vlc-devel] [PATCH] fixed misc/stats.c:399: warning: comparison between signed and unsigned in function '__stats_TimerClean'

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Wed, 16 Apr 2008 21:21:33 -0400,
Michael Ploujnikov <ploujj at gmail.com> a écrit :

> Based on usage of i_id, other stats_* functions and my opinion i_id
> should be unsigned int instead of int, but I might be missing the
> bigger picture related to changing public APIs. Please, let me know
> how to correctly deal with such warnings.

It's correct, the good way is to look at the definitions, for instance
counter_t structure in vlc_messages.h:

struct counter_t
{
    unsigned int        i_id;
...

Applied, thanks

- -- 
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIBuOdYWCeGMCv8Q8RAn4xAKCUSfFaJ7X2G4ryKp4H0kNzOoaXMgCgicPM
YQTMbpEruvJ2jq+AU48Qgxs=
=Xq8H
-----END PGP SIGNATURE-----