[vlc-devel] commit: httpd: Fix vlc_object_wait() usage. It' s needed to check if we were not already killed before calling vlc_object_wait (). Thanks to William King for spotting the deadlock. (Pierre d'Herbemont )

[Pierre d'Herbemont]

On Apr 22, 2008, at 5:34 PM, Rémi Denis-Courmont wrote:
> Le Tuesday 22 April 2008 18:11:07 git version control, vous avez  
> écrit :
>> vlc | branch: master | Pierre d'Herbemont  
>> <pdherbemont at videolan.org> | Tue
>> Apr 22 17:11:46 2008 +0200|  
>> [baffdc120c6a63cc32988535578f44158deb59d5]
>>
>> httpd: Fix vlc_object_wait() usage. It's needed to check if we were  
>> not
>> already killed before calling vlc_object_wait(). Thanks to William  
>> King for
>> spotting the deadlock.
>
> Right. The more I look at the wait pipe, the more I feel it's awful,  
> and we
> should have been using cancellation instead. In the mean time, it's
> impossible for a thread to sleep anyway except through poll() or
> vlc_object_wait(). waitpipe() does not work with mwait() and  
> mdate(), neither
> does vlc_cond_wait() and vlc_cond_timedwait() (using a custom  
> condition
> variable), nor the usual I/O functions.

Do you plan to use it? Wasn't windows a hurdle for cancelation point?

Pierre.