[vlc-devel] [PATCH]Improved nuv demuxer and new rtjpeg decoder

[Derk-Jan Hartman]

I have not been able to test the demux, and the rtjpeg patch will not  
be applied until its reentrancy issues are fixed I think.

I have opened bug tickets for both patches:
http://trac.videolan.org/vlc/ticket/1812
http://trac.videolan.org/vlc/ticket/1813

Both are currently set for 0.9.1

DJ

On 23 jul 2008, at 11:41, Gertjan Van Droogenbroeck wrote:
> Hello,
>
> On Tue, Jul 22, 2008 at 9:56 PM, Rémi Denis-Courmont
> <rdenis at simphalempin.com> wrote:
>> Some problems with the nuv patch:
>>
>> Please do not use packed structures unless there is no other way,  
>> as this is
>> not portable. You anyway have to do byte endianness conversion.  
>> NEVER EVER
>> use non-fixed integers inside packed structures.
> It no longer uses the packed structures. It now uses fixed offsets.
>
>> There is no need to use vlc_memcpy() for a small fixed size header.  
>> The
>> function call overhead might be worse than using plain non-optimized
>> memcpy(). You should probably use block_Realloc() instead of
>> block_Alloc()+memcpy() anyway.
> I didn't know block_Realloc could be used for that, I thought it
> worked like realloc. It now uses block_Realloc()+memcpy().
>
>> The format string for int64_t is "%"PRI64d, not "%lld". The format  
>> string for
>> size_t (including sizeof()) is "%zu", not "%d".
> The format strings are changed, I also replaced it in the code that
> was already there.
>
> I also fixed a bug with the GET_LENGTH calculations in unseekable  
> streams.
>