[vlc-devel] commit: Remove stupid test and error message. ( Rémi Duraffort )

[git version control]

vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Mon Aug  4 21:11:48 2008 +0200| [00cc9dcaaef99e5238ee4f5d8b4bdc2c5689d87c] | committer: Rémi Duraffort 

Remove stupid test and error message.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=00cc9dcaaef99e5238ee4f5d8b4bdc2c5689d87c
---

 modules/visualization/visual/effects.c |    2 --
 modules/visualization/visual/visual.c  |    8 +-------
 2 files changed, 1 insertions(+), 9 deletions(-)

diff --git a/modules/visualization/visual/effects.c b/modules/visualization/visual/effects.c
index 2b83cc8..6566f4f 100644
--- a/modules/visualization/visual/effects.c
+++ b/modules/visualization/visual/effects.c
@@ -315,8 +315,6 @@ int spectrum_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
     fft_close( p_state );
 
     free( p_s16_buff );
-    p_s16_buff = NULL;
-
     free( height );
 
     return 0;
diff --git a/modules/visualization/visual/visual.c b/modules/visualization/visual/visual.c
index 2f1351a..73a71a6 100644
--- a/modules/visualization/visual/visual.c
+++ b/modules/visualization/visual/visual.c
@@ -203,10 +203,7 @@ static int Open( vlc_object_t *p_this )
 
     p_sys = p_filter->p_sys = malloc( sizeof( aout_filter_sys_t ) );
     if( p_sys == NULL )
-    {
-        msg_Err( p_filter, "out of memory" );
         return VLC_EGENERIC;
-    }
 
     p_sys->i_height = config_GetInt( p_filter , "effect-height");
     p_sys->i_width  = config_GetInt( p_filter , "effect-width");
@@ -296,10 +293,7 @@ static int Open( vlc_object_t *p_this )
         }
     }
 
-    if( psz_effects )
-    {
-        free( psz_effects );
-    }
+    free( psz_effects );
 
     if( !p_sys->i_effect )
     {