[vlc-devel] Reentrancy and non-const static variables

[Justus-bulk at Piater.name]

Thanks for the heads up, but I'm not eligible for this honor - none of
my changes had any functional implications (except perhaps the
VCDFormatStr() patch).  All I did was declare some static variables
const, in obvious cases only, intending to reduce the sea of non-const
statics to make the real problems easier to spot.

Some others followed up with some real fixes, which may have already
had an effect on the plugin.

However, I don't think the problem has been fixed; the diagnostic
given at Ticket #686 is likely correct. If I find some time during the
coming weeks, I'll give it a shot; I need the plugin for my work.

Besides this, there are probably other problems though; many of the
reentrancy issues I found during my quick survey look potentially
serious. Keep squashing 'em, folks... :-)

Justus


Jean-Baptiste Kempf <jb at videolan.org> wrote on Tue, 5 Aug 2008
10:03:13 -0700:

> On Sun, Aug 03, 2008 at 10:42:28AM +0200, Justus Piater wrote :
>> The VLC code has lots of reentrancy problems, at least one of which is
>> probably responsible for Firefox crashing if multiple VLC plugin
>> instances are present (Ticket #686). As a first shot, I've grepped for
>
> Multiple users confirm that those changes did fix many IE/ActiveX and
> Mozilla plugins crashes.