[vlc-devel] commit: poll(): ifndef HAVE_POLL means we don't use poll(), not that it doesn't exist. In OSX poll() is broken for sockets, so we don' t use it. Since poll is a kernel function in OSX however, the kernel implementation was used whenever we used poll(), instead of VLCs private poll() which was the intended behaviour. Renamed poll() to vlc_poll() to prevent this. (Derk-Jan Hartman )

[Rémi Denis-Courmont]

Le mercredi 6 août 2008 18:16:22 Rémi Denis-Courmont, vous avez écrit :
> Le mercredi 6 août 2008 17:58:47 git version control, vous avez écrit :
> > vlc | branch: master | Derk-Jan Hartman <hartman at videolan.org> | Wed Aug 
> > 6 16:58:02 2008 +0200| [d934fc525f6be873a56c54dd97d0aa8f5fead910] |
> > committer: Derk-Jan Hartman
> >
> > VLCs private poll() which was the
> > intended behaviour. Renamed poll() to vlc_poll() to prevent this.
>
> Oh no, it was NOT the intended behavior. The VLC poll() implementation
> (which I wrote) will _only_ work properly on Winsock. It is not intended
> for any other OS, and explicitly NOT adequate for BSD variants.

P.S.: this commit introduces a remotely triggerable buffer-overflow on OSX.

-- 
Rémi Denis-Courmont
http://www.remlab.net/