[vlc-devel] commit: Remove the progressBar in the interface to show more clearly the bug in AVI fixing . Add debug too... (Jean-Baptiste Kempf )

git version control git at videolan.org
Wed Aug 6 23:23:01 CEST 2008


vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Wed Aug  6 14:24:42 2008 -0700| [3f9a678b312bb55716719ef35a2315f3ce541366] | committer: Jean-Baptiste Kempf 

Remove the progressBar in the interface to show more clearly the bug in AVI fixing. Add debug too...

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3f9a678b312bb55716719ef35a2315f3ce541366
---

 modules/gui/qt4/dialogs/interaction.cpp |   14 ++------------
 modules/gui/qt4/dialogs_provider.cpp    |    2 ++
 modules/gui/qt4/main_interface.cpp      |    4 ----
 modules/gui/qt4/main_interface.hpp      |    2 --
 4 files changed, 4 insertions(+), 18 deletions(-)

diff --git a/modules/gui/qt4/dialogs/interaction.cpp b/modules/gui/qt4/dialogs/interaction.cpp
index fab6569..cf18662 100644
--- a/modules/gui/qt4/dialogs/interaction.cpp
+++ b/modules/gui/qt4/dialogs/interaction.cpp
@@ -104,18 +104,8 @@ InteractionDialog::InteractionDialog( intf_thread_t *_p_intf,
         panel->setLayout( grid );
         layout->addWidget( panel );
     }
-    else if( p_dialog->i_flags & DIALOG_INTF_PROGRESS )
-    {
-        if( p_intf->p_sys->p_mi )
-        {
-            progressBar = p_intf->p_sys->p_mi->pgBar;
-            progressBar->show();
-            i_ret = 2;
-        }
-        else
-            p_dialog->i_flags = DIALOG_USER_PROGRESS;
-    }
-    else if( p_dialog->i_flags & DIALOG_USER_PROGRESS )
+    else if( (p_dialog->i_flags & DIALOG_INTF_PROGRESS ) ||
+             ( p_dialog->i_flags & DIALOG_USER_PROGRESS ) )
     {
         dialog = new QWidget( 0 );layout = new QVBoxLayout( dialog );
         layout->setMargin( 2 );
diff --git a/modules/gui/qt4/dialogs_provider.cpp b/modules/gui/qt4/dialogs_provider.cpp
index 93bfe8c..d296bef 100644
--- a/modules/gui/qt4/dialogs_provider.cpp
+++ b/modules/gui/qt4/dialogs_provider.cpp
@@ -580,12 +580,14 @@ void DialogsProvider::doInteraction( intf_dialog_args_t *p_arg )
         }
         break;
     case INTERACT_HIDE:
+        msg_Dbg( p_intf, "Hide the Interaction Dialog" );
         qdialog = (InteractionDialog*)(p_dialog->p_private);
         if( qdialog )
             qdialog->hide();
         p_dialog->i_status = HIDDEN_DIALOG;
         break;
     case INTERACT_DESTROY:
+        msg_Dbg( p_intf, "Destroy the Interaction Dialog" );
         qdialog = (InteractionDialog*)(p_dialog->p_private);
         if( !p_dialog->i_flags & DIALOG_NONBLOCKING_ERROR )
             delete qdialog;
diff --git a/modules/gui/qt4/main_interface.cpp b/modules/gui/qt4/main_interface.cpp
index d413dae..718b61b 100644
--- a/modules/gui/qt4/main_interface.cpp
+++ b/modules/gui/qt4/main_interface.cpp
@@ -57,7 +57,6 @@
 #include <QToolBar>
 #include <QGroupBox>
 #include <QDate>
-#include <QProgressBar>
 
 #include <assert.h>
 #include <vlc_keys.h>
@@ -306,13 +305,10 @@ inline void MainInterface::createStatusBar()
     speedLabel->setFrameStyle( QFrame::Sunken | QFrame::Panel );
     nameLabel->setFrameStyle( QFrame::Sunken | QFrame::StyledPanel);
 
-    pgBar = new QProgressBar;
-    pgBar->hide();
 
     /* and adding those */
     statusBar()->addWidget( nameLabel, 8 );
     statusBar()->addPermanentWidget( speedLabel, 0 );
-    statusBar()->addPermanentWidget( pgBar, 0 );
     statusBar()->addPermanentWidget( timeLabel, 0 );
 
     /* timeLabel behaviour:
diff --git a/modules/gui/qt4/main_interface.hpp b/modules/gui/qt4/main_interface.hpp
index d4acacc..3a1ff9b 100644
--- a/modules/gui/qt4/main_interface.hpp
+++ b/modules/gui/qt4/main_interface.hpp
@@ -50,7 +50,6 @@ class SpeedControlWidget;
 class QMenu;
 class QSize;
 //class QDockWidet;
-class QProgressBar;
 
 enum{
     CONTROLS_HIDDEN = 0x0,
@@ -104,7 +103,6 @@ private:
     FullscreenControllerWidget *fullscreenControls;
     QMenu               *speedControlMenu;
     SpeedControlWidget  *speedControl;
-    QProgressBar        *pgBar;
 
     void handleMainUi( QSettings* );
     void askForPrivacy();




More information about the vlc-devel mailing list