[vlc-devel] commit: update: Don't release the thread object from this precise thread. ( Pierre d'Herbemont )

[git version control]

vlc | branch: master | Pierre d'Herbemont <pdherbemont at videolan.org> | Sun Aug 10 22:17:12 2008 +0200| [e7d43dd44d9b2de967c8a8097f3eeb7e3d914c2e] | committer: Pierre d'Herbemont 

update: Don't release the thread object from this precise thread.

This is not safe and not supported.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e7d43dd44d9b2de967c8a8097f3eeb7e3d914c2e
---

 src/misc/update.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/misc/update.c b/src/misc/update.c
index 4e83249..d1620eb 100644
--- a/src/misc/update.c
+++ b/src/misc/update.c
@@ -1079,6 +1079,7 @@ void update_Delete( update_t *p_update )
     {
         vlc_object_kill( p_update->p_download );
         vlc_thread_join( p_update->p_download );
+        vlc_object_release( p_update->p_download );
     }
 
     vlc_mutex_destroy( &p_update->lock );
@@ -1682,9 +1683,6 @@ end:
     free( p_buffer );
     free( psz_size );
 
-    p_udt->p_update->p_download = NULL;
-
-    vlc_object_release( p_udt );
     return NULL;
 }