[vlc-devel] [PATCH]Fix for the shoutcast bug in Qt playlist

Pierre d'Herbemont pdherbemont at free.fr
Tue Aug 12 01:54:34 CEST 2008

On Aug 11, 2008, at 9:22 PM, Geoffroy Couprie wrote:

> I removed the --playlist-tree, it is now always taking effect. That
> was the easier way to workaround #1668. AFAIK it won't harm the other
> interfaces, the b_tree option was a Qt only thing.
> Please review, comment, and push, or slap me in the face if that's a
> bad patch :)

I don't use Qt so I may be biaised. It makes sense to stop using that  
b_tree option. This introduces some overhead in the playlist code, and  
is mostly the reason why it is hard to maintain.

Yet doing so would probably break displaying the Qt4 interfaces as  
flat view. I don't know if someone cares.

An other alternative is to revert  
1f26dd3fc7a3a285a00e5e84db113ae4b496da5b and  
722ab9f14ee31f8f0633cfc7a0b79401c47316fe. And to set the removed input- 
 >b_prefers_tree correctly in the shoutcast module.


More information about the vlc-devel mailing list