[vlc-devel] commit: Revert "Turn on -Werror for libvlccore and libvlc." ( Rémi Denis-Courmont )

[Pierre d'Herbemont]

On Aug 14, 2008, at 8:27 AM, Rémi Denis-Courmont wrote:

>
> On Thu, 14 Aug 2008 01:32:34 +0200, Pierre d'Herbemont
> <pdherbemont at free.fr> wrote:
>>> A warning is a warning is a warning. According to the GCC
>>> documentation
>>> itself, "warnings are made optional because GCC is not smart enough
>>> to see
>>> all the reasons why the code might be correct despite appearing to
>>> have an
>>> error". And my experience is that other compilers are much worse.
>>
>>
>> Ok. Do you agree then to turn -Werror when building when --enable- 
>> debug?
>
> No. Never.
>
> If you want -Werror, do it yourself in your *own* CFLAGS.

Come on, the idea is not to set it have only me to bother with  
warnings, but to impose a general warning wary policy.

>
>> The idea is to get enough of us to build with -Werror, without trying
>> to afraid new comers.
>
> So we forbid porters to other platforms from enabling debug,  
> precisely in
> the cases that it would be most useful...

You forgot to reply to the buildbot only Werror option... I guess that  
mean that you agree.

Pierre.